Skip to main content

Early Review of draft-ietf-idr-bfd-subcode-03
review-ietf-idr-bfd-subcode-03-rtgdir-early-boucadair-2022-10-05-00

Request Review of draft-ietf-idr-bfd-subcode
Requested revision No specific revision (document currently at 05)
Type Early Review
Team Routing Area Directorate (rtgdir)
Deadline 2022-11-05
Requested 2022-09-30
Requested by Keyur Patel
Authors Jeffrey Haas
I-D last updated 2022-10-05
Completed reviews Secdir Early review of -04 by Melinda Shore (diff)
Rtgdir Early review of -03 by Mohamed Boucadair (diff)
Genart Last Call review of -04 by Elwyn B. Davies (diff)
Comments
Please review and provide your comments!
Assignment Reviewer Mohamed Boucadair
State Completed
Request Early review on draft-ietf-idr-bfd-subcode by Routing Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/rtg-dir/MTymh27VWhWxgmCl2V4MzXlwh7A
Reviewed revision 03 (document currently at 05)
Result Has issues
Completed 2022-10-05
review-ietf-idr-bfd-subcode-03-rtgdir-early-boucadair-2022-10-05-00
Document: draft-ietf-idr-bfd-subcode-03
Reviewer: Mohamed Boucadair
Review Date: 05/10/2022
IETF LC End Date: N/A
Intended Status: Standards Track

I have been selected to do a routing directorate “early” review of this draft.

# General

The specification is on good track and its core contribution is ready. However,
there are some very few points that I suggest to fix:

## Use consistent terminology (see more in the detailed review provided below)

## Consider adding a pointer to the BGP YANG module as an example to tweak the
associated BFD timers. Likewise, consider listing last-error (YANG) data node
in addition to the MIB mention.

## The Security Considerations Section should ACK at least the dependency on
the BFD to take actions. Manipulating the BFD session will thus have
implications on the BGP connection.

## IANA Considerations: The assignment is currently temporary (as per
https://www.iana.org/assignments/bgp-parameters/bgp-parameters.xhtml#bgp-parameters-4).
IANA should be requested to make that assignment permanent. I would update the
text accordingly.

## Consider moving at least RFC8538 to be listed as normative.

# Detailed Review:

FWIW, my detailed review can be found at:

* pdf:
https://github.com/boucadair/IETF-Drafts-Reviews/raw/master/draft-ietf-idr-bfd-subcode-03-rev%20Med.pdf
* doc:
https://github.com/boucadair/IETF-Drafts-Reviews/raw/master/draft-ietf-idr-bfd-subcode-03-rev%20Med.doc