Skip to main content

Last Call Review of draft-ietf-lsr-isis-fast-flooding-05
review-ietf-lsr-isis-fast-flooding-05-rtgdir-lc-andersson-2023-11-06-00

Request Review of draft-ietf-lsr-isis-fast-flooding
Requested revision No specific revision (document currently at 11)
Type Last Call Review
Team Routing Area Directorate (rtgdir)
Deadline 2023-09-22
Requested 2023-08-31
Requested by Acee Lindem
Authors Bruno Decraene , Les Ginsberg , Tony Li , Guillaume Solignac , Marek Karasek , Gunter Van de Velde , Tony Przygienda
I-D last updated 2023-11-06
Completed reviews Tsvart Last Call review of -07 by Mirja Kühlewind (diff)
Secdir Last Call review of -07 by Barry Leiba (diff)
Genart Last Call review of -07 by Ines Robles (diff)
Rtgdir Last Call review of -05 by Loa Andersson (diff)
Tsvart Early review of -06 by Mirja Kühlewind (diff)
Assignment Reviewer Loa Andersson
State Completed
Request Last Call review on draft-ietf-lsr-isis-fast-flooding by Routing Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/rtg-dir/L_c9J_7QIsFsrVMB7OifUKM06UI
Reviewed revision 05 (document currently at 11)
Result Ready
Completed 2023-10-07
review-ietf-lsr-isis-fast-flooding-05-rtgdir-lc-andersson-2023-11-06-00
Hello,

I have been selected as the Routing Directorate reviewer for this draft. 
The Routing Directorate seeks to review all routing or routing-related 
drafts as they pass through IETF last call and IESG review, and 
sometimes on special request. The purpose of the review is to provide 
assistance to the Routing ADs. For more information about the Routing 
Directorate, please see https://wiki.ietf.org/en/group/rtg/RtgDir

Although these comments are primarily for the use of the Routing ADs, it 
would be helpful if you could consider them along with any other IETF 
Last Call comments that you receive, and strive to resolve them through 
discussion or by updating the draft.

Document: draft-ietf-lsr-isis-fast-flooding (the current version is -05)
Reviewer: Loa Andersson
Review Date: 2023-10-08
IETF LC End Date:
Intended Status: Experimental

Summary:

This document is basically ready for publication; I only found one issue 
- the number of authors listed.

Document Overview:
Current Link State Protocol Data Unit (PDU) flooding rates are much 
slower than what modern networks can support.  The use of IS-IS at 
larger scale requires faster flooding rates to achieve desired 
convergence goals.  This document discusses the need for faster 
flooding, the issues around faster flooding, and some example approaches 
to achieve faster flooding.  It also defines protocol extensions 
relevant to faster flooding.

Comments:

The draft is well-written and easy to read. I gone over the IANA 
Considerations and allocations, and not found anything that need to be 
addressed.

Major Issues:

Number of authors: There are 7 authors, that is more the the "allowed" 5 
authors.

I have no background why there 7 authors listed, this has to be 
addressed in some way:

- reduce the number of authors to five

- keep the number of authors at seven, and the Shepherd will have to
    address this in the SWU,

I have put this as a "major issue" since I don't know where to put it.

My personal opinion is that anyone that has contributed text to the 
document, and participated in the authors discussions, should be listed 
as an author.

"No minor issues found."

Nits:

The nits-tool only finds a  Miscellaneous warning:

-- The document date (5 September 2023) is 32 days in the past.  Is this
      intentional?

This warning is a bit annoying since it is impossible to avoid.

I have not found any other nits.


/Loa


-- 
Loa Andersson                        email: loa@pi.nu
Senior MPLS Expert                          loa.pi.nu@gmail.com
Bronze Dragon Consulting             phone: +46 739 81 21 64