Last Call Review of draft-ietf-netconf-netconf-client-server-04
review-ietf-netconf-netconf-client-server-04-yangdoctors-lc-bierman-2017-07-28-00

Request Review of draft-ietf-netconf-netconf-client-server-04
Requested rev. 04 (document currently at 22)
Type Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2017-07-31
Requested 2017-07-10
Requested by Mehmet Ersue
Authors Kent Watsen
Draft last updated 2017-07-28
Completed reviews Yangdoctors Last Call review of -04 by Andy Bierman (diff)
Assignment Reviewer Andy Bierman 
State Completed
Review review-ietf-netconf-netconf-client-server-04-yangdoctors-lc-bierman-2017-07-28
Reviewed rev. 04 (document currently at 22)
Review result Ready with Nits
Review completed: 2017-07-28

Review
review-ietf-netconf-netconf-client-server-04-yangdoctors-lc-bierman-2017-07-28

Review: draft-ietf-netconf-netconf-client-server-04

Modules:
 (M1) ietf-netconf-client@2017-07-03.yang
 (M2) ietf-netconf-server@2017-07-03.yang


YANG Usage:

 I did not find anything wrong in either module.
 pyang and yangdump-pro do not report any errors or warnings.

Comments:

C1:

 (M1) feature ssh-initiate
 (M1) feature ssh-listen
 (M2) feature ssh-listen
 (M2) feature ssh-call-home

 Are these features really needed since a NETCONF server MUST support
 the SSH transport?

C2:

Sec 1.2 Tree Diagrams

Old text should be replaced with reference to
draft-ietf-netmod-yang-tree-diagrams-01

C3: Sec 2.1:

Should use the new version of pyang that expands leafref nodes
in tree diagrams.

C4:

 (M1) IETF copyright says 2014; change to 2017
 (M2) IETF copyright says 2014; change to 2017