Last Call Review of draft-ietf-netext-wifi-epc-eap-attributes-08
review-ietf-netext-wifi-epc-eap-attributes-08-secdir-lc-johansson-2014-07-10-00

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG.  These comments were written primarily for the benefit of the
security area directors.  Document editors and WG chairs should treat
these comments just like any other last call comments.

The drafts define a set of EAP attributes for signalling wifi handover
from 3gpp devices. In general the draft is well written.

I believe the draft is more or less ready. I have two comments, one of
which is stylistic and the other may be just me misunderstanding the
EAP-AKA handshake...

1. In a few places the draft sais that the defined attributes SHOULD be
used. I would qualify this to say that "mobile nodes implementing the
spec SHOULD" since EAP is used in a lot of situations where 3gpp _could_
be used but isn't.

2. It seems like AT_CONNECTIVITY_TYPE is signalled before the EAP
challenge is completed. Unless I misunderstood something I think this
warrants a discussion in the Security Considerations section. Currently
the text in that section only talks about when attributes are to be
processed but there is no discussion of possible threats based on when
attributes are transmitted.

	Cheers Leif