Last Call Review of draft-ietf-nmop-terminology-12
review-ietf-nmop-terminology-12-iotdir-lc-bormann-2025-02-25-00
Request | Review of | draft-ietf-nmop-terminology |
---|---|---|
Requested revision | No specific revision (document currently at 16) | |
Type | IETF Last Call Review | |
Team | Internet of Things Directorate (iotdir) | |
Deadline | 2025-02-18 | |
Requested | 2025-01-30 | |
Requested by | Mohamed Boucadair | |
Authors | Nigel Davis , Adrian Farrel , Thomas Graf , Qin Wu , Chaode Yu | |
I-D last updated | 2025-04-18 (Latest revision 2025-04-15) | |
Completed reviews |
Secdir Early review of -07
by Hilarie Orman
(diff)
Genart Early review of -07 by Paul Kyzivat (diff) Opsdir Early review of -07 by Jouni Korhonen (diff) Rtgdir Early review of -07 by Stewart Bryant (diff) Iotdir Early review of -07 by Carsten Bormann (diff) Intdir Early review of -07 by Dirk Von Hugo (diff) Iotdir IETF Last Call review of -12 by Carsten Bormann (diff) Genart IETF Last Call review of -10 by Paul Kyzivat (diff) Secdir IETF Last Call review of -10 by Hilarie Orman (diff) |
|
Comments |
You kindly reviewed an early version of the document. Your review was very useful and triggered changes that were implemented by the authors. Now that the document is in the WGLC, we would like to double check that your issues were adequately handled. Of course, we welcome new comments and issues that you might have. Thank you |
|
Assignment | Reviewer | Carsten Bormann |
State | Completed | |
Request | IETF Last Call review on draft-ietf-nmop-terminology by Internet of Things Directorate Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/iot-directorate/fTUHIc6JCOs_U-fjQ72WlJy-2MA | |
Reviewed revision | 12 (document currently at 16) | |
Result | Ready w/issues | |
Completed | 2025-02-25 |
review-ietf-nmop-terminology-12-iotdir-lc-bormann-2025-02-25-00
(Insert IOTDIR review boilerplate here.) My apologies for the tardy completion of this review assignment. Thank you again for doing this work, and for considering my feedback to the -07 revision of this draft. I read this document anew (trying not to be influenced by my older review, which I believe you have taken care of). I believe this is almost ready to publish, limited to a few (smaller) actual issues. These and some more nitpicking below. (Page numbers below are with respect to a PDF rendering that I had to create on my own as the data tracker cannot currently create a proper PDF form of I-Ds. Please find it, with the markups referenced below, at: https://tzi.org/~cabo/draft-ietf-nmop-terminology-12-marked.pdf ) ## Minor * Box, page 4 metadata This is the only occurrence I find for this word, and I'm not sure if I understand why it is used here; I think it means something different than the result of processing some data. * Anchored Note, page 4 Observability This term is interesting, as its name suggests a capability, not a process. There probably will be no confusion among the intended consumers of this terminology, but this small dissonance may be worth half a sentence. * Anchored Note, page 4 data gathered This is now saying that Network Monitoring exclusively feeds from Telemetry, and what Monitoring mostly is concerned with is keeping a record of that. Naïvely, I would expect there are some additional sources of information that go into that record, particularly events on the intent side. E.g., you would monitor that an interface went down, but you also would monitor (take into the record) that it was administratively shut down -- that will certainly help with making sense of the Event. * Anchored Note, page 6 Thus a Fault happens at a moment in time So a Fault always goes away right after this moment in time? I’m not sure that this is an intuitive (i.e., familiar) usage of this term. * Anchored Note, page 7 requires ➔ may require (except for false alarms) * Anchored Note, page 12 Fault Management Is this just a statement about fault management? (There is one more place where "Fault Management" is used and maybe "Fault and Problem Management" is meant; otherwise the document is very careful to use the latter, so I'm wondering whether there is a semantics difference here.) ## Editorial * Highlight, page 4 behavior, and to identify, anomalies Can't parse. * Highlight, page 4 where This fragment is not really trying to be a sentence with the bullet items following it. * Anchored Note, page 6 whilst a Problem is unresolved it may continue to require attention This is not surprising. What is the note trying to say? I looked up “whilst” (which I'm not seeing very often), and maybe this BE word doesn’t help my understanding. whilst | (h)waɪlst | British English conjunction 1 during the time that; at the same time as: Michael runs the island co-operative whilst Mary runs the pub | the natural resources are used up whilst the population continues to increase. 2 whereas (indicating a contrast): some employers have a relaxed dress code, whilst others insist on formal attire. * Anchored Note, page 7 relationship Figure 1 misses out on the 1:n (1:1? m:n?) nature of the relationships. ## Nits * Highlight, page 3 help to set (There is a "help distinguish" above -- is it to or not to?) * Circle, page 4 ta . Th (Spurious blank space.) * Circle, page 5 d. (Missing closing parenthesis.) * Anchored Note, page 6 which ➔ that (No comma ➔ I read this as a restricting clause, which is easier to understand with “that”.) * Highlight, page 6 consider a loss of light State may cause Hard to parse. * Anchored Note, page 7 PAs s/PAs/As/