Early Review of draft-ietf-i2rs-yang-l2-network-topology-04
review-ietf-i2rs-yang-l2-network-topology-04-yangdoctors-early-lhotka-2018-05-02-00

Request Review of draft-ietf-i2rs-yang-l2-network-topology
Requested revision No specific revision (document currently at 18)
Type Early Review
Team YANG Doctors (yangdoctors)
Deadline 2018-03-21
Requested 2018-03-07
Requested by Susan Hares
Authors Jie Dong , Xiugang Wei , Qin Wu , Mohamed Boucadair , Anders Liu
I-D last updated 2018-05-02
Completed reviews Rtgdir Early review of -02 by Henning Rogge (diff)
Rtgdir Early review of -04 by Henning Rogge (diff)
Yangdoctors Early review of -04 by Ladislav Lhotka (diff)
Rtgdir Last Call review of -13 by Stig Venaas (diff)
Yangdoctors Last Call review of -13 by Ladislav Lhotka (diff)
Genart Last Call review of -13 by Meral Shirazipour (diff)
Secdir Last Call review of -13 by Christian Huitema (diff)
Secdir Telechat review of -14 by Christian Huitema (diff)
Comments 
It would be helpful to have the review done before the I2RS meeting at IETF 101
Assignment Reviewer Ladislav Lhotka
State Completed
Request Early review on draft-ietf-i2rs-yang-l2-network-topology by YANG Doctors Assigned
Reviewed revision 04 (document currently at 18)
Result Ready
Completed 2018-05-02
review-ietf-i2rs-yang-l2-network-topology-04-yangdoctors-early-lhotka-2018-05-02-00
This draft and YANG modules contained therein fit into the framework of I2RS
network topology models. I have no substantial comments, from the YANG point of
view this document is ready to be published.

Comments and questions:

1. What is the purpose of the 'flag-type' type and 'flag-identity' identity?
There are no identities derived from the latter.

2. Some descriptions overuse capitalization. For example, instead of 'VLAN
Name' I would suggest 'VLAN name'.

3. An example of an instance document in an appendix would be very helpful.