Last Call Review of draft-ietf-netconf-tcp-client-server-21
review-ietf-netconf-tcp-client-server-21-tsvart-lc-tuexen-2024-02-12-00
Request | Review of | draft-ietf-netconf-tcp-client-server |
---|---|---|
Requested revision | No specific revision (document currently at 26) | |
Type | Last Call Review | |
Team | Transport Area Review Team (tsvart) | |
Deadline | 2024-02-12 | |
Requested | 2024-01-29 | |
Authors | Kent Watsen , Michael Scharf | |
I-D last updated | 2024-02-12 | |
Completed reviews |
Genart Last Call review of -21
by Mallory Knodel
(diff)
Secdir Last Call review of -21 by Nancy Cam-Winget (diff) Opsdir Last Call review of -20 by Bo Wu (diff) Yangdoctors Last Call review of -09 by Ladislav Lhotka (diff) Tsvart Last Call review of -21 by Michael Tüxen (diff) |
|
Assignment | Reviewer | Michael Tüxen |
State | Completed | |
Request | Last Call review on draft-ietf-netconf-tcp-client-server by Transport Area Review Team Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/tsv-art/eYeU6g3lm_1I4rH3ZZrm3skHNpQ | |
Reviewed revision | 21 (document currently at 26) | |
Result | Ready w/nits | |
Completed | 2024-02-12 |
review-ietf-netconf-tcp-client-server-21-tsvart-lc-tuexen-2024-02-12-00
This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them to address any issues raised and also to the IETF discussion list for information. When done at the time of IETF Last Call, the authors should consider this review as part of the last-call comments they receive. Please always CC tsv-art@ietf.org if you reply to or forward this review. The document is well written, I only have the following two nits: * 2.1.5. Guidelines for Configuring TCP Keep-Alives It seems that the item list at the end of the subsection provides information related to "idle-time", "max-probes", and "probe-interval". One item for one leaf, in the given order. What confuses me is that the first item contains: "but keep-alive messages SHOULD NOT be transmitted more frequently than once every 15 seconds" For me, this applies to not only to "idle-time" but also to "probe-interval". However, for "probe-interval" you provide lower values. Using "A lower value MAY be configured, but idle intervals SHOULD NOT be smaller than 15 seconds. Longer idle intervals SHOULD be used when possible." would have avoided this confusion. * Acknowledgements The authors would like to thank for following for lively discussions should possibly read The authors would like to thank the following for lively discussions Best regards Michael Tüxen