Early Review of draft-ietf-tictoc-1588v2-yang-07

Request Review of draft-ietf-tictoc-1588v2-yang
Requested rev. no specific revision (document currently at 11)
Type Early Review
Team Internet Area Directorate (intdir)
Deadline 2018-06-22
Requested 2018-06-08
Requested by Suresh Krishnan
Authors Yuanlong Jiang, Xian Liu, Jinchun Xu, Rodney Cummings
Draft last updated 2018-06-14
Completed reviews Intdir Early review of -07 by Dave Thaler (diff)
Opsdir Last Call review of -09 by Sheng Jiang (diff)
Genart Last Call review of -09 by Linda Dunbar (diff)
Secdir Last Call review of -10 by Samuel Weiler (diff)
Genart Telechat review of -10 by Linda Dunbar (diff)
Yangdoctors Early review of -10 by Radek Krejčí (diff)
Assignment Reviewer Dave Thaler
State Completed
Review review-ietf-tictoc-1588v2-yang-07-intdir-early-thaler-2018-06-14
Reviewed rev. 07 (document currently at 11)
Review result Ready with Nits
Review completed: 2018-06-14


I have reviewed draft-ietf-tictoc-1588v2-yang-07 as assigned int-dir reviewer.
The draft was readable and technically good (though I am not an expert on either YANG or IEEE 1588-2008.
I do have a number of nits indicated in the marked up copy at

The most notable piece of feedback is that it's not clear what the units are for several integer objects.