Early Review of draft-ietf-babel-hmac-00

Request Review of draft-ietf-babel-hmac
Requested rev. no specific revision (document currently at 12)
Type Early Review
Team Routing Area Directorate (rtgdir)
Deadline 2018-09-24
Requested 2018-08-27
Requested by Donald Eastlake
Authors Clara Do, Weronika Kolodziejak, Juliusz Chroboczek
Draft last updated 2018-09-19
Completed reviews Rtgdir Early review of -00 by Mike McBride (diff)
Secdir Early review of -00 by Robert Sparks (diff)
Rtgdir Last Call review of -07 by Mike McBride (diff)
Genart Last Call review of -07 by David Schinazi (diff)
Secdir Last Call review of -07 by Robert Sparks (diff)
Opsdir Last Call review of -08 by Dan Romascanu (diff)
QA review.
Assignment Reviewer Mike McBride 
State Completed Snapshot
Review review-ietf-babel-hmac-00-rtgdir-early-mcbride-2018-09-19
Reviewed rev. 00 (document currently at 12)
Review result Has Nits
Review completed: 2018-09-19


I have been selected to do a routing directorate "early" review of draft-ietf-babel-hmac.

Document: draft-ietf-babel-hmac-00
Reviewer: Mike McBride
Review Date: 19-09-2018

Intended Status: Standards Track


I only found a few nits. Great job with the draft, especially being a 00. The nits that should be considered:

1.      Add a Terminology section to include HMAC, Babel, PC, etc

2.      1.1 Applicability Section: "The protocol defined in this document assumes that all interfaces on a given link are equally trusted and share a small set of symmetric keys (usually just one, two during key rotation)." Consider changing it to: "...(Typically one key. Two keys during a key rotation)." Otherwise it can read as "just one or two during key rotation".

3.      4.2 Packet Transmission Section: "A Babel node may delay actually sending TLVs by a small amount...". Consider giving an example of a small amount.

Sound reasonable?