Skip to main content

Telechat Review of draft-ietf-rtgwg-yang-rib-extend-21
review-ietf-rtgwg-yang-rib-extend-21-opsdir-telechat-wu-2023-06-06-00

Request Review of draft-ietf-rtgwg-yang-rib-extend
Requested revision No specific revision (document currently at 24)
Type Telechat Review
Team Ops Directorate (opsdir)
Deadline 2023-06-06
Requested 2023-05-02
Authors Acee Lindem , Yingzhen Qu
I-D last updated 2023-06-06
Completed reviews Yangdoctors Last Call review of -17 by Martin Björklund (diff)
Rtgdir Last Call review of -16 by Zhaohui (Jeffrey) Zhang (diff)
Secdir Last Call review of -16 by Chris M. Lonvick (diff)
Opsdir Telechat review of -21 by Bo Wu (diff)
Yangdoctors Last Call review of -03 by Christian Hopps (diff)
Yangdoctors Last Call review of -06 by Martin Björklund (diff)
Rtgdir Last Call review of -06 by Emmanuel Baccelli (diff)
Assignment Reviewer Bo Wu
State Completed
Request Telechat review on draft-ietf-rtgwg-yang-rib-extend by Ops Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/J2BnIitvEGAVniulBcAgQH2o4iA
Reviewed revision 21 (document currently at 24)
Result Has nits
Completed 2023-06-06
review-ietf-rtgwg-yang-rib-extend-21-opsdir-telechat-wu-2023-06-06-00
Hi,

I have reviewed the document and it is clear written.

Here are two nits commments:

In Section 5. RIB Extension YANG Model
1)
 OLD:
    description
       "This YANG module extends the RIB defined in the ietf-routing
        YANG module with additionalroute attributes.
NEW:
    description
       "This YANG module extends the RIB defined in the ietf-routing
        YANG module with additional route attributes.

2) grouping next-hop is defined but not used, is this intentional?

Thanks,
Bo Wu